Skip to content

Edit feature for calendars and events#113

Merged
AlexisChoupault merged 9 commits into
sncf-connect-tech:mainfrom
AlexisChoupault:feature/editing
Jun 12, 2026
Merged

Edit feature for calendars and events#113
AlexisChoupault merged 9 commits into
sncf-connect-tech:mainfrom
AlexisChoupault:feature/editing

Conversation

@AlexisChoupault

@AlexisChoupault AlexisChoupault commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@AlexisChoupault AlexisChoupault self-assigned this Jun 4, 2026
@AlexisChoupault AlexisChoupault linked an issue Jun 4, 2026 that may be closed by this pull request
Edit feature for existing calendars/events #19
Closed
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 4, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for updating calendars and events across Android, iOS, and Flutter, including updating Pigeon-generated files, native platform implementations, mock event stores, UI components, and unit tests. The code review identified critical compilation errors on both Android and iOS: the Android implementations of updateCalendar and updateEvent incorrectly use Result<Unit> instead of returning the updated Calendar and Event objects as expected by the Pigeon interface, and the iOS mock implementations in MockEasyEventStore similarly mismatch the EasyEventStoreProtocol return types. Additionally, the corresponding unit tests on Android must be updated to match these corrected signatures.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread android/src/main/kotlin/sncf/connect/tech/eventide/CalendarImplem.kt
Comment thread android/src/main/kotlin/sncf/connect/tech/eventide/CalendarImplem.kt
Comment thread android/src/test/kotlin/sncf/connect/tech/eventide/CalendarTests.kt
Comment thread android/src/test/kotlin/sncf/connect/tech/eventide/EventTests.kt
Comment thread example/ios/EventideTests/Mocks/MockEasyEventStore.swift Outdated
Comment thread example/ios/EventideTests/Mocks/MockEasyEventStore.swift Outdated
@codecov

codecov Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.09%. Comparing base (623a791) to head (69593f0).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #113      +/-   ##
============================================
- Coverage     90.12%   88.09%   -2.04%     
- Complexity      110      115       +5     
============================================
  Files            23       23              
  Lines          3910     4207     +297     
  Branches        100      112      +12     
============================================
+ Hits           3524     3706     +182     
- Misses          319      422     +103     
- Partials         67       79      +12
Flag Coverage Δ
unittests 88.09% <100.00%> (-2.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexisChoupault

AlexisChoupault commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini all good?

@gemini-code-assist

gemini-code-assist Bot commented Jun 11, 2026

Copy link
Copy Markdown

The implementation of the updateCalendar and updateEvent features looks solid and follows the existing patterns in the codebase. However, as noted by the Codecov report, the new logic in lib/src/eventide.dart currently lacks test coverage. To ensure the robustness of these new features, please add unit tests for these methods in your test suite. Once those tests are added and passing, the coverage should improve, and the implementation will be in good shape.

@AlexisChoupault AlexisChoupault force-pushed the feature/editing branch 2 times, most recently from fc77849 to 1d7c23b Compare June 11, 2026 06:21
@AlexisChoupault AlexisChoupault merged commit 2912b2a into sncf-connect-tech:main Jun 12, 2026
13 checks passed
@AlexisChoupault AlexisChoupault deleted the feature/editing branch June 12, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@AlexisChoupault AlexisChoupault

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Edit feature for existing calendars/events

1 participant

@AlexisChoupault